change name of subscription stubbing method to add clarity of intent
Dieser Commit ist enthalten in:
Ursprung
13fb5dc1ea
Commit
c8263ed6aa
30 geänderte Dateien mit 35 neuen und 35 gelöschten Zeilen
|
@ -42,7 +42,7 @@ describe CustomWizard::Action do
|
|||
}
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
Group.refresh_automatic_group!(:trust_level_2)
|
||||
update_template(wizard_template)
|
||||
end
|
||||
|
|
|
@ -29,7 +29,7 @@ describe CustomWizard::Builder do
|
|||
}
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
Group.refresh_automatic_group!(:trust_level_3)
|
||||
CustomWizard::Template.save(wizard_template, skip_jobs: true)
|
||||
@template = CustomWizard::Template.find('super_mega_fun_wizard')
|
||||
|
|
|
@ -5,7 +5,7 @@ describe CustomWizard::CustomField do
|
|||
let(:custom_field_subscription_json) { get_wizard_fixture("custom_field/subscription_custom_fields") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::CustomField.invalidate_cache
|
||||
end
|
||||
|
||||
|
|
|
@ -7,7 +7,7 @@ describe CustomWizard::Submission do
|
|||
let(:guest_id) { CustomWizard::Wizard.generate_guest_id }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Template.save(template_json, skip_jobs: true)
|
||||
@wizard = CustomWizard::Wizard.create(template_json["id"], user)
|
||||
described_class.new(@wizard, step_1_field_1: "I am user submission").save
|
||||
|
|
|
@ -15,7 +15,7 @@ describe CustomWizard::Subscription do
|
|||
|
||||
context "with subscription client gem mocked out" do
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
end
|
||||
|
||||
context "without a subscription" do
|
||||
|
|
|
@ -7,7 +7,7 @@ describe CustomWizard::Template do
|
|||
fab!(:upload) { Fabricate(:upload) }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Template.save(template_json, skip_jobs: true)
|
||||
end
|
||||
|
||||
|
|
|
@ -40,7 +40,7 @@ describe CustomWizard::TemplateValidator do
|
|||
end
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
end
|
||||
|
||||
it "validates valid templates" do
|
||||
|
|
|
@ -6,7 +6,7 @@ describe CustomWizard::UpdateValidator do
|
|||
let(:url_field) { get_wizard_fixture("field/url") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Template.save(template, skip_jobs: true)
|
||||
@template = CustomWizard::Template.find('super_mega_fun_wizard')
|
||||
end
|
||||
|
|
|
@ -10,7 +10,7 @@ describe CustomWizard::Wizard do
|
|||
let(:step_json) { get_wizard_fixture("step/step") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
Group.refresh_automatic_group!(:trust_level_3)
|
||||
@permitted_template = template_json.dup
|
||||
@permitted_template["permitted"] = permitted_json["permitted"]
|
||||
|
|
|
@ -11,7 +11,7 @@ describe "custom field extensions" do
|
|||
let(:subscription_custom_field_json) { get_wizard_fixture("custom_field/subscription_custom_fields") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
custom_field_json['custom_fields'].each do |field_json|
|
||||
custom_field = CustomWizard::CustomField.new(nil, field_json)
|
||||
custom_field.save
|
||||
|
|
|
@ -7,7 +7,7 @@ describe ExtraLocalesControllerCustomWizard, type: :request do
|
|||
let(:permitted) { get_wizard_fixture("wizard/permitted") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Template.save(template, skip_jobs: true)
|
||||
end
|
||||
|
||||
|
|
|
@ -33,7 +33,7 @@ describe ::Guardian do
|
|||
end
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Template.save(wizard_template, skip_jobs: true)
|
||||
@template = CustomWizard::Template.find('super_mega_fun_wizard')
|
||||
end
|
||||
|
|
|
@ -6,7 +6,7 @@ describe InvitesControllerCustomWizard, type: :request do
|
|||
let(:template) { get_wizard_fixture("wizard") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
@controller = InvitesController.new
|
||||
end
|
||||
|
||||
|
|
|
@ -4,7 +4,7 @@ describe CustomWizardUsersController, type: :request do
|
|||
let(:template) { get_wizard_fixture("wizard") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
@controller = UsersController.new
|
||||
end
|
||||
|
||||
|
|
|
@ -9,13 +9,13 @@ def get_wizard_fixture(path)
|
|||
end
|
||||
|
||||
def enable_subscription(type)
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Subscription.stubs("#{type}?".to_sym).returns(true)
|
||||
CustomWizard::Subscription.any_instance.stubs("#{type}?".to_sym).returns(true)
|
||||
end
|
||||
|
||||
def disable_subscriptions
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
%w[
|
||||
standard
|
||||
business
|
||||
|
@ -26,11 +26,11 @@ def disable_subscriptions
|
|||
end
|
||||
end
|
||||
|
||||
def undefine_client_classes
|
||||
def unstub_out_subscription_classes
|
||||
Object.send(:remove_const, :DiscourseSubscriptionClient) if Object.constants.include?(:DiscourseSubscriptionClient)
|
||||
Object.send(:remove_const, :SubscriptionClientSubscription) if Object.constants.include?(:SubscriptionClientSubscription)
|
||||
end
|
||||
|
||||
def define_client_classes
|
||||
def stub_out_subscription_classes
|
||||
load File.expand_path("#{Rails.root}/plugins/discourse-custom-wizard/spec/fixtures/subscription_client.rb", __FILE__)
|
||||
end
|
||||
|
|
|
@ -5,7 +5,7 @@ describe CustomWizard::AdminApiController do
|
|||
let(:api_json) { get_wizard_fixture("api/api") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
sign_in(admin_user)
|
||||
end
|
||||
|
||||
|
|
|
@ -5,7 +5,7 @@ describe CustomWizard::AdminCustomFieldsController do
|
|||
let(:custom_field_json) { get_wizard_fixture("custom_field/custom_fields") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
custom_field_json['custom_fields'].each do |field_json|
|
||||
CustomWizard::CustomField.new(nil, field_json).save
|
||||
end
|
||||
|
|
|
@ -5,7 +5,7 @@ describe CustomWizard::AdminLogsController do
|
|||
let(:template) { get_wizard_fixture("wizard") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
["first", "second", "third"].each_with_index do |key, index|
|
||||
temp = template.dup
|
||||
temp["id"] = "#{key}_test_wizard"
|
||||
|
|
|
@ -5,7 +5,7 @@ describe CustomWizard::AdminManagerController do
|
|||
let(:template) { get_wizard_fixture("wizard") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
sign_in(admin_user)
|
||||
|
||||
template_2 = template.dup
|
||||
|
|
|
@ -1,6 +1,6 @@
|
|||
# frozen_string_literal: true
|
||||
|
||||
describe CustomWizard::AdminController do
|
||||
describe CustomWizard::SubscriptionController do
|
||||
fab!(:admin_user) { Fabricate(:user, admin: true) }
|
||||
|
||||
it "requires an admin" do
|
||||
|
@ -16,7 +16,7 @@ describe CustomWizard::AdminController do
|
|||
context "without a subscription" do
|
||||
before do
|
||||
disable_subscriptions
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
end
|
||||
|
||||
it "returns the right subscription details" do
|
||||
|
@ -29,7 +29,7 @@ describe CustomWizard::AdminController do
|
|||
context "with a subscription" do
|
||||
before do
|
||||
enable_subscription("standard")
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
end
|
||||
|
||||
it "returns the right subscription details" do
|
||||
|
|
|
@ -5,7 +5,7 @@ describe ApplicationController do
|
|||
let(:wizard_template) { get_wizard_fixture("wizard") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Template.save(wizard_template, skip_jobs: true)
|
||||
@template = CustomWizard::Template.find('super_mega_fun_wizard')
|
||||
end
|
||||
|
|
|
@ -10,7 +10,7 @@ describe "custom field extensions" do
|
|||
let(:subscription_custom_field_json) { get_wizard_fixture("custom_field/subscription_custom_fields") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
custom_field_json['custom_fields'].each do |field_json|
|
||||
custom_field = CustomWizard::CustomField.new(nil, field_json)
|
||||
custom_field.save
|
||||
|
|
|
@ -11,7 +11,7 @@ describe CustomWizard::StepsController do
|
|||
let(:guests_permitted) { get_wizard_fixture("wizard/guests_permitted") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Template.save(wizard_template, skip_jobs: true)
|
||||
end
|
||||
|
||||
|
|
|
@ -6,7 +6,7 @@ describe CustomWizard::WizardController do
|
|||
let(:permitted_json) { get_wizard_fixture("wizard/permitted") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Template.save(wizard_template, skip_jobs: true)
|
||||
@template = CustomWizard::Template.find("super_mega_fun_wizard")
|
||||
end
|
||||
|
|
|
@ -5,7 +5,7 @@ describe CustomWizard::BasicWizardSerializer do
|
|||
let(:template) { get_wizard_fixture("wizard") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
end
|
||||
|
||||
it 'should return basic wizard attributes' do
|
||||
|
|
|
@ -5,7 +5,7 @@ describe CustomWizard::CustomFieldSerializer do
|
|||
let(:custom_field_json) { get_wizard_fixture("custom_field/custom_fields") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
end
|
||||
|
||||
it 'should return custom field attributes' do
|
||||
|
|
|
@ -13,7 +13,7 @@ describe CustomWizard::SubmissionSerializer do
|
|||
}
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Template.save(template_json, skip_jobs: true)
|
||||
|
||||
wizard = CustomWizard::Wizard.create(template_json["id"], user1)
|
||||
|
|
|
@ -5,7 +5,7 @@ describe CustomWizard::FieldSerializer do
|
|||
let(:template) { get_wizard_fixture("wizard") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Template.save(template, skip_jobs: true)
|
||||
@wizard = CustomWizard::Builder.new("super_mega_fun_wizard", user).build
|
||||
end
|
||||
|
|
|
@ -8,7 +8,7 @@ describe CustomWizard::WizardSerializer do
|
|||
let(:advanced_fields) { get_wizard_fixture("field/advanced_types") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Template.save(template, skip_jobs: true)
|
||||
@template = CustomWizard::Template.find('super_mega_fun_wizard')
|
||||
end
|
||||
|
|
|
@ -6,7 +6,7 @@ describe CustomWizard::StepSerializer do
|
|||
let(:required_data_json) { get_wizard_fixture("step/required_data") }
|
||||
|
||||
before do
|
||||
define_client_classes
|
||||
stub_out_subscription_classes
|
||||
CustomWizard::Template.save(wizard_template, skip_jobs: true)
|
||||
@wizard = CustomWizard::Builder.new("super_mega_fun_wizard", user).build
|
||||
end
|
||||
|
|
Laden …
In neuem Issue referenzieren