From 866926501f95c5217f78ba23bcc1f94ad931509a Mon Sep 17 00:00:00 2001 From: jbrw Date: Tue, 29 Sep 2020 12:57:32 -0400 Subject: [PATCH 1/2] REFACTOR - remove _.debounce and _.isEqual Lodash is being removed from core Discourse. --- .../discourse/mixins/undo-changes.js.es6 | 47 ++++++++++--------- .../javascripts/wizard/lib/user-search.js.es6 | 3 +- 2 files changed, 26 insertions(+), 24 deletions(-) diff --git a/assets/javascripts/discourse/mixins/undo-changes.js.es6 b/assets/javascripts/discourse/mixins/undo-changes.js.es6 index 43df47f4..776be1cd 100644 --- a/assets/javascripts/discourse/mixins/undo-changes.js.es6 +++ b/assets/javascripts/discourse/mixins/undo-changes.js.es6 @@ -3,14 +3,15 @@ import { default as wizardSchema } from '../lib/wizard-schema'; import { set, get } from "@ember/object"; import Mixin from "@ember/object/mixin"; import { observes } from 'discourse-common/utils/decorators'; +import { deepEqual } from 'discourse-common/lib/object'; export default Mixin.create({ didInsertElement() { this._super(...arguments); this.setupObservers(); - + const obj = this.get(this.componentType); - + this.setProperties({ originalObject: JSON.parse(JSON.stringify(obj)), undoIcon: obj.isNew ? 'times' : 'undo', @@ -22,11 +23,11 @@ export default Mixin.create({ this._super(...arguments); this.removeObservers(); }, - + removeObservers(objType=null) { const componentType = this.componentType; const obj = this.get(componentType); - + let opts = { objectType: objType || obj.type } @@ -35,44 +36,44 @@ export default Mixin.create({ obj.removeObserver(property, this, this.toggleUndo); }); }, - + setupObservers(objType=null) { const componentType = this.componentType; const obj = this.get(componentType); - + let opts = { objectType: objType || obj.type } - + listProperties(componentType, opts).forEach(property => { obj.addObserver(property, this, this.toggleUndo); }); }, - + revertToOriginal(revertBasic=false) { const original = JSON.parse(JSON.stringify(this.originalObject)); const componentType = this.componentType; const obj = this.get(componentType); const objSchema = wizardSchema[componentType]; const basicDefaults = objSchema.basic; - + if (revertBasic) { Object.keys(basicDefaults).forEach(property => { let value; - + if (original.hasOwnProperty(property)) { value = get(original, property); } else if (basicDefaults.hasOwnProperty(property)) { value = get(basicDefaults, property); } - + set(obj, property, value); }); } - + if (objSchema.types && obj.type) { let typeDefaults = objSchema.types[obj.type]; - + Object.keys(typeDefaults).forEach(property => { let value; @@ -81,45 +82,45 @@ export default Mixin.create({ } else if (typeDefaults.hasOwnProperty(property)) { value = get(typeDefaults, property); } - + set(obj, property, value); }); } }, - + toggleUndo() { const current = this.get(this.componentType); const original = this.originalObject; - this.set('showUndo', !_.isEqual(current, original)); + this.set('showUndo', !deepEqual(current, original)); }, - + actions: { undoChanges() { const componentType = this.componentType; const original = this.get('originalObject'); const obj = this.get(componentType); - + this.removeObservers(obj.type); this.revertToOriginal(true); this.set('showUndo', false); this.setupObservers(this.get(componentType).type); }, - + changeType(type) { const componentType = this.componentType; const original = this.get('originalObject'); const obj = this.get(componentType); - + this.removeObservers(obj.type); obj.set('type', type); this.revertToOriginal(); this.set('showUndo', type !== original.type); this.setupObservers(type); }, - + mappedFieldUpdated(property, mappedComponent, type) { const obj = this.get(this.componentType); - obj.notifyPropertyChange(property); + obj.notifyPropertyChange(property); } } -}) \ No newline at end of file +}) diff --git a/assets/javascripts/wizard/lib/user-search.js.es6 b/assets/javascripts/wizard/lib/user-search.js.es6 index 6b242fd4..617825d1 100644 --- a/assets/javascripts/wizard/lib/user-search.js.es6 +++ b/assets/javascripts/wizard/lib/user-search.js.es6 @@ -1,5 +1,6 @@ import { CANCELLED_STATUS } from 'discourse/lib/autocomplete'; import getUrl from 'discourse-common/lib/get-url'; +import discourseDebounce from "discourse/lib/debounce"; var cache = {}, cacheTopicId, @@ -39,7 +40,7 @@ function performSearch(term, topicId, includeGroups, includeMentionableGroups, i }); } -var debouncedSearch = _.debounce(performSearch, 300); +var debouncedSearch = discourseDebounce(performSearch, 300); function organizeResults(r, options) { if (r === CANCELLED_STATUS) { return r; } From fce7b77a9138d232791edd70f14a798481a56cb8 Mon Sep 17 00:00:00 2001 From: Angus McLeod Date: Thu, 1 Oct 2020 20:23:39 +1000 Subject: [PATCH 2/2] Add share-url import --- assets/javascripts/wizard-custom.js | 1 + 1 file changed, 1 insertion(+) diff --git a/assets/javascripts/wizard-custom.js b/assets/javascripts/wizard-custom.js index c88cf204..5840393c 100644 --- a/assets/javascripts/wizard-custom.js +++ b/assets/javascripts/wizard-custom.js @@ -76,6 +76,7 @@ //= require discourse/app/helpers/category-link //= require discourse/app/helpers/user-avatar //= require discourse/app/helpers/format-username +//= require discourse/app/helpers/share-url //= require discourse-common/addon/helpers/component-for-collection //= require discourse-common/addon/helpers/component-for-row //= require discourse-common/addon/lib/raw-templates