Spiegel von
https://github.com/paviliondev/discourse-custom-wizard.git
synchronisiert 2024-11-22 09:20:29 +01:00
51553bc71d
* DEV: validate liquid templates on wizard save * minor fix * code improvements and spec * version bump * fixed failing specs * FIX: handle displaying backend validation errors on frontend * fixed linting * improved error display * validate raw description for steps * refactor conditional * Identify attribute with liquid template error and pass syntax error Co-authored-by: angusmcleod <angus@mcleod.org.au> Co-authored-by: Angus McLeod <angusmcleod@users.noreply.github.com>
132 Zeilen
3,3 KiB
Ruby
132 Zeilen
3,3 KiB
Ruby
# frozen_string_literal: true
|
|
class CustomWizard::TemplateValidator
|
|
include HasErrors
|
|
include ActiveModel::Model
|
|
|
|
def initialize(data, opts = {})
|
|
@data = data
|
|
@opts = opts
|
|
end
|
|
|
|
def perform
|
|
data = @data
|
|
|
|
check_id(data, :wizard)
|
|
check_required(data, :wizard)
|
|
validate_after_signup
|
|
validate_after_time
|
|
|
|
return false if errors.any?
|
|
|
|
data[:steps].each do |step|
|
|
check_required(step, :step)
|
|
validate_liquid_template(step, :step)
|
|
|
|
if step[:fields].present?
|
|
step[:fields].each do |field|
|
|
check_required(field, :field)
|
|
validate_liquid_template(field, :field)
|
|
end
|
|
end
|
|
end
|
|
|
|
if data[:actions].present?
|
|
data[:actions].each do |action|
|
|
check_required(action, :action)
|
|
validate_liquid_template(action, :action)
|
|
end
|
|
end
|
|
|
|
!errors.any?
|
|
end
|
|
|
|
def self.required
|
|
{
|
|
wizard: ['id', 'name', 'steps'],
|
|
step: ['id'],
|
|
field: ['id', 'type'],
|
|
action: ['id', 'type']
|
|
}
|
|
end
|
|
|
|
private
|
|
|
|
def check_required(object, type)
|
|
CustomWizard::TemplateValidator.required[type].each do |property|
|
|
if object[property].blank?
|
|
errors.add :base, I18n.t("wizard.validation.required", property: property)
|
|
end
|
|
end
|
|
end
|
|
|
|
def check_id(object, type)
|
|
if type === :wizard && @opts[:create] && CustomWizard::Template.exists?(object[:id])
|
|
errors.add :base, I18n.t("wizard.validation.conflict", wizard_id: object[:id])
|
|
end
|
|
end
|
|
|
|
def validate_after_signup
|
|
return unless ActiveRecord::Type::Boolean.new.cast(@data[:after_signup])
|
|
|
|
other_after_signup = CustomWizard::Template.list(setting: 'after_signup')
|
|
.select { |template| template['id'] != @data[:id] }
|
|
|
|
if other_after_signup.any?
|
|
errors.add :base, I18n.t("wizard.validation.after_signup", wizard_id: other_after_signup.first['id'])
|
|
end
|
|
end
|
|
|
|
def validate_after_time
|
|
return unless ActiveRecord::Type::Boolean.new.cast(@data[:after_time])
|
|
|
|
if ActiveRecord::Type::Boolean.new.cast(@data[:after_signup])
|
|
errors.add :base, I18n.t("wizard.validation.after_signup_after_time")
|
|
return
|
|
end
|
|
|
|
wizard = CustomWizard::Wizard.create(@data[:id]) if !@opts[:create]
|
|
current_time = wizard.present? ? wizard.after_time_scheduled : nil
|
|
new_time = @data[:after_time_scheduled]
|
|
|
|
begin
|
|
active_time = Time.parse(new_time.present? ? new_time : current_time).utc
|
|
rescue ArgumentError
|
|
invalid_time = true
|
|
end
|
|
|
|
if invalid_time || active_time.blank? || active_time < Time.now.utc
|
|
errors.add :base, I18n.t("wizard.validation.after_time")
|
|
end
|
|
end
|
|
|
|
def validate_liquid_template(object, type)
|
|
%w[
|
|
description
|
|
raw_description
|
|
placeholder
|
|
preview_template
|
|
post_template
|
|
].each do |field|
|
|
if template = object[field]
|
|
result = is_liquid_template_valid?(template)
|
|
|
|
unless "valid" == result
|
|
error = I18n.t("wizard.validation.liquid_syntax_error",
|
|
attribute: "#{object[:id]}.#{field}",
|
|
message: result
|
|
)
|
|
errors.add :base, error
|
|
end
|
|
end
|
|
end
|
|
end
|
|
|
|
def is_liquid_template_valid?(template)
|
|
begin
|
|
Liquid::Template.parse(template)
|
|
'valid'
|
|
rescue Liquid::SyntaxError => error
|
|
error.message
|
|
end
|
|
end
|
|
end
|