From e7635b632c915df46fb7fc77e62ef7b2b3af5866 Mon Sep 17 00:00:00 2001 From: Faizaan Gagan Date: Wed, 27 Jan 2021 10:48:22 +0530 Subject: [PATCH 1/2] added dynamic attributes that can be targetted via css (#67) --- assets/javascripts/wizard/helpers/char-counter.js.es6 | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/assets/javascripts/wizard/helpers/char-counter.js.es6 b/assets/javascripts/wizard/helpers/char-counter.js.es6 index c27c0818..6a9bb120 100644 --- a/assets/javascripts/wizard/helpers/char-counter.js.es6 +++ b/assets/javascripts/wizard/helpers/char-counter.js.es6 @@ -6,7 +6,8 @@ export default registerUnbound("char-counter", function(body, maxLength) { let finalString; if (maxLength) { - finalString = `
${bodyLength} / ${I18n.t('wizard.x_characters', { count: parseInt(maxLength) })}
`; + let isOverMax = bodyLength > maxLength ? "true" : "false"; + finalString = `
${bodyLength} / ${I18n.t('wizard.x_characters', { count: parseInt(maxLength) })}
`; } else { finalString = `
${I18n.t('wizard.x_characters', { count: parseInt(bodyLength) })}
`; } From 2681fe21adae1645dcac6aa0386524578e6185b8 Mon Sep 17 00:00:00 2001 From: Faizaan Gagan Date: Wed, 27 Jan 2021 11:43:09 +0530 Subject: [PATCH 2/2] FIX: wizard composer size should be consistent accross broswers (#68) --- assets/stylesheets/wizard/custom/composer.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/assets/stylesheets/wizard/custom/composer.scss b/assets/stylesheets/wizard/custom/composer.scss index d747bfcb..50dd5219 100644 --- a/assets/stylesheets/wizard/custom/composer.scss +++ b/assets/stylesheets/wizard/custom/composer.scss @@ -132,7 +132,7 @@ .d-editor-input { border: 0; padding: 10px; - height: 100%; + height: unset; // overrides core css overflow-x: hidden; resize: none; }