From f908e5ec9d5bd2bcfeee0a066004dcddd5d9364d Mon Sep 17 00:00:00 2001 From: angusmcleod Date: Wed, 20 Oct 2021 21:19:21 +0800 Subject: [PATCH] Add spec for fix --- spec/components/custom_wizard/builder_spec.rb | 19 +++++++++++++++++++ .../condition/boolean_field_condition.json | 17 +++++++++++++++++ spec/fixtures/wizard.json | 6 ++++++ 3 files changed, 42 insertions(+) create mode 100644 spec/fixtures/condition/boolean_field_condition.json diff --git a/spec/components/custom_wizard/builder_spec.rb b/spec/components/custom_wizard/builder_spec.rb index 8e80d806..def54fc4 100644 --- a/spec/components/custom_wizard/builder_spec.rb +++ b/spec/components/custom_wizard/builder_spec.rb @@ -47,6 +47,14 @@ describe CustomWizard::Builder do ) } + let(:boolean_field_condition_json) { + JSON.parse( + File.open( + "#{Rails.root}/plugins/discourse-custom-wizard/spec/fixtures/condition/boolean_field_condition.json" + ).read + ) + } + before do Group.refresh_automatic_group!(:trust_level_3) CustomWizard::Template.save( @@ -322,6 +330,7 @@ describe CustomWizard::Builder do context "with condition" do before do @template[:steps][0][:fields][0][:condition] = user_condition_json['condition'] + @template[:steps][2][:fields][5][:condition] = boolean_field_condition_json['condition'] CustomWizard::Template.save(@template.as_json) end @@ -334,6 +343,16 @@ describe CustomWizard::Builder do wizard = CustomWizard::Builder.new(@template[:id], user).build expect(wizard.steps.first.fields.first.id).to eq(@template[:steps][0][:fields][1]['id']) end + + it "works if a field condition uses 'is true/false'" do + builder = CustomWizard::Builder.new(@template[:id], user) + wizard = builder.build + wizard.create_updater('step_2', step_2_field_5: 'true').update + + builder = CustomWizard::Builder.new(@template[:id], user) + wizard = builder.build + expect(wizard.steps.last.fields.last.id).to eq(@template[:steps][2][:fields][5]['id']) + end end end diff --git a/spec/fixtures/condition/boolean_field_condition.json b/spec/fixtures/condition/boolean_field_condition.json new file mode 100644 index 00000000..6a264e71 --- /dev/null +++ b/spec/fixtures/condition/boolean_field_condition.json @@ -0,0 +1,17 @@ +{ + "condition": [ + { + "type": "validation", + "pairs": [ + { + "index": 0, + "key": "step_2_field_5", + "key_type": "wizard_field", + "value": "true", + "value_type": "text", + "connector": "is" + } + ] + } + ] +} \ No newline at end of file diff --git a/spec/fixtures/wizard.json b/spec/fixtures/wizard.json index a505c0d3..4727c7a8 100644 --- a/spec/fixtures/wizard.json +++ b/spec/fixtures/wizard.json @@ -157,6 +157,12 @@ "label": "User Selector", "description": "", "type": "user_selector" + }, + { + "id": "step_3_field_6", + "label": "Conditional User Selector", + "description": "Shown when checkbox in step_2_field_5 is true", + "type": "user_selector" } ], "description": "Unfortunately not the edible type :sushi: "