Add enabled? wrapper for CustomField extensions

coverage/.last_run.json

@@ -1,5 +1,5 @@
 {
   "result": {
-    "covered_percent": 89.17
+    "covered_percent": 89.25
   }
 }

extensions/custom_field/preloader.rb

@@ -1,6 +1,6 @@
 module CustomWizardCustomFieldPreloader
   def preload_custom_fields(objects, fields)
-    if objects.present?
+    if objects.present? && cw_fields_enabled?
       @cw_klass = objects.first.class.name.underscore
       if cw_fields.any?
         cw_fields.each do |field|
@@ -11,6 +11,10 @@ module CustomWizardCustomFieldPreloader
     super(objects, fields)
   end
   
+  def cw_fields_enabled?
+    SiteSetting.custom_wizard_enabled && CustomWizard::CustomField.enabled?
+  end
+  
   def cw_fields
     CustomWizard::CustomField.list_by(:klass, @cw_klass)
   end

extensions/custom_field/serializer.rb

@@ -1,14 +1,17 @@
 module CustomWizardCustomFieldSerializer
   def attributes(*args)
     hash = super
-    @cw_klass = get_cw_class
     
-    if cw_fields.any?
+    if cw_fields_enabled?
-      cw_fields.each do |field|
+      @cw_klass = get_cw_class
-        if @cw_klass == "topic_view"
+      
-          hash[field.name.to_sym] = object.topic.custom_fields["#{field.name}"]
+      if cw_fields.any?
-        else
+        cw_fields.each do |field|
-          hash[field.name.to_sym] = object.custom_fields["#{field.name}"]
+          if @cw_klass == "topic_view"
+            hash[field.name.to_sym] = object.topic.custom_fields["#{field.name}"]
+          else
+            hash[field.name.to_sym] = object.custom_fields["#{field.name}"]
+          end
         end
       end
     end
@@ -17,6 +20,10 @@ module CustomWizardCustomFieldSerializer
   end
   
   private
+  
+  def cw_fields_enabled?
+    SiteSetting.custom_wizard_enabled && CustomWizard::CustomField.enabled?
+  end
 
   def cw_fields
     CustomWizard::CustomField.list_by(:serializers, @cw_klass)

lib/custom_wizard/custom_field.rb

@@ -122,6 +122,7 @@ class ::CustomWizard::CustomField
   
   def self.reset
     @list = nil
+    @any = nil
   end
   
   def self.list
@@ -199,4 +200,16 @@ class ::CustomWizard::CustomField
     Discourse.clear_readonly!
     Discourse.request_refresh!
   end
+  
+  def self.any?
+    if @any.nil?
+      @any = PluginStoreRow.where(plugin_name: NAMESPACE).exists?
+    else
+      @any
+    end
+  end
+  
+  def self.enabled?
+    any?
+  end
 end

plugin.rb

@@ -173,11 +173,13 @@ after_initialize do
   
   CustomWizard::CustomField::CLASSES.keys.each do |klass|
     add_model_callback(klass, :after_initialize) do
-      CustomWizard::CustomField.list_by(:klass, klass.to_s).each do |field|
+      if CustomWizard::CustomField.enabled?
-        klass.to_s
+        CustomWizard::CustomField.list_by(:klass, klass.to_s).each do |field|
-          .classify
+          klass.to_s
-          .constantize
+            .classify
-          .register_custom_field_type(field.name, field.type.to_sym)
+            .constantize
+            .register_custom_field_type(field.name, field.type.to_sym)
+        end
       end
     end
     

spec/components/custom_wizard/custom_field_spec.rb

@@ -175,4 +175,15 @@ describe CustomWizard::CustomField do
       expect(CustomWizard::CustomField.list_by(:klass, 'topic').length).to eq(1)
     end
   end
+  
+  it "is enabled if there are custom fields" do
+    custom_field_json['custom_fields'].each do |field_json|
+      CustomWizard::CustomField.new(nil, field_json).save
+    end
+    expect(CustomWizard::CustomField.enabled?).to eq(true)
+  end
+  
+  it "is not enabled if there are no custom fields" do
+    expect(CustomWizard::CustomField.enabled?).to eq(false)
+  end
 end