Merge pull request #26 from merefield/national_flags_better_integration

REMOVE: all redundant nat flags logic that has been moved to national flags plugin

assets/javascripts/discourse/components/wizard-custom-field.js.es6

@@ -32,12 +32,7 @@ export default Ember.Component.extend({
         name: I18n.t('admin.wizard.field.choices_preset.tags')
       }
     ];
-    if (Discourse.SiteSettings.nationalflag_enabled) {
+    
-        presets.push({
-          id: 'flags',
-          name: I18n.t('admin.wizard.field.choices_preset.flags')
-        })
-    }
     return presets;
   },
 

assets/javascripts/wizard/initializers/custom.js.es6

@@ -29,19 +29,6 @@ export default {
         
     registerRawHelpers(RawHandlebars, Handlebars);
 
-    WizardFieldDropdown.reopen({
-      tagName: 'span',
-      classNames: ['wizard-select-value'],
-
-      @computed
-      isFlagSelector() {
-          const field = this.get('field');
-          //TODO improve the way this detects a flag dropdown (currently it relies on the string 'Nation', e.g. 'Nationality' or 'National Flag' appearing in label)
-            return  (typeof field.label !== 'undefined') ? (field.label.includes(Discourse.SiteSettings.wizard_national_flags_label_cue)) ?  true :  false : false;
-        }
-    });
-
-
     // IE11 Polyfill - https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries#Polyfill
     if (!Object.entries)
       Object.entries = function( obj ){

assets/javascripts/wizard/templates/components/wizard-field-dropdown.hbs

@@ -5,6 +5,3 @@
             none=(hash id="__none__" label=field.dropdown_none)
             nameProperty="label"
             tabindex="9"}}
-{{#if isFlagSelector}}
-    <img class="nationalflag-usersummary" src="/plugins/discourse-nationalflags/images/nationalflags/{{field.value}}.png" />
-{{/if}}

config/locales/client.en.yml

@@ -103,7 +103,6 @@ en:
             categories: "Categories"
             groups: "Groups"
             tags: "Tags"
-            flags: "Flags"
             filter: "Preset Filter"
           choice:
             value: "Value"

config/locales/server.en.yml

@@ -23,4 +23,3 @@ en:
   site_settings:
     wizard_redirect_exclude_paths: "Routes excluded from wizard redirects."
     wizard_recognised_image_upload_formats: "File types which will result in upload displaying an image preview"
-    wizard_national_flags_label_cue: "The characters that must appear in the dropdown field label for it to show a flag"

config/settings.yml

@@ -12,6 +12,3 @@ plugins:
     refresh: true
     type: list
     list_type: compact
-  wizard_national_flags_label_cue:
-    client: true
-    default: "National"

lib/builder.rb

@@ -290,10 +290,6 @@ class CustomWizard::Builder
         objects = Tag.top_tags(guardian: guardian).map { |tag| TagStruct.new(tag,tag) }
       end
 
-      if field_template['choices_preset'] === 'flags'
-        objects = CustomWizard::Flags.list
-      end
-
       if field_template['choices_filters'] && field_template['choices_filters'].length > 0
         field_template['choices_filters'].each do |f|
           objects.reject! do |o|

lib/flags.rb

@@ -1,31 +0,0 @@
-class CustomWizard::Flag
-    def initialize(id, name)
-        @id = id
-        @name = name
-    end
-
-    def id
-        @id
-    end
-
-    def name
-        @name
-    end
-end
-
-class CustomWizard::Flags
-
-    def self.list
-        raw_flags = YAML.safe_load(File.read(File.join(Rails.root, 'plugins', 'discourse-custom-wizard', 'config', 'national_flags.yml')))
-
-        flagscollection = []
-
-        raw_flags.map do |name, pic| 
-            # This is super hacky.  Adding the trailing space actually stops search breaking in the dropdown! (and doesn't compromise the view!)
-            # Feeding just name, name will break search
-            flagscollection << CustomWizard::Flag.new(name, "#{name} ")
-        end
-
-        flagscollection
-    end
-end

plugin.rb

@@ -85,7 +85,6 @@ after_initialize do
   load File.expand_path('../jobs/set_after_time_wizard.rb', __FILE__)
   load File.expand_path('../lib/builder.rb', __FILE__)
   load File.expand_path('../lib/field.rb', __FILE__)
-  load File.expand_path('../lib/flags.rb', __FILE__)
   load File.expand_path('../lib/step_updater.rb', __FILE__)
   load File.expand_path('../lib/template.rb', __FILE__)
   load File.expand_path('../lib/wizard.rb', __FILE__)