0
0
Fork 1
Spiegel von https://github.com/paviliondev/discourse-custom-wizard.git synchronisiert 2024-11-22 17:30:29 +01:00
discourse-custom-wizard/spec/components/custom_wizard/template_validator_spec.rb

243 Zeilen
8,6 KiB
Ruby

2021-03-11 07:30:15 +01:00
# frozen_string_literal: true
2020-11-03 01:24:20 +01:00
describe CustomWizard::TemplateValidator do
2024-10-16 13:52:03 +02:00
fab!(:user)
2021-09-07 14:06:13 +02:00
let(:template) { get_wizard_fixture("wizard") }
let(:create_category) { get_wizard_fixture("actions/create_category") }
let(:user_condition) { get_wizard_fixture("condition/user_condition") }
2022-03-25 17:08:24 +01:00
let(:permitted_json) { get_wizard_fixture("wizard/permitted") }
let(:composer_preview) { get_wizard_fixture("field/composer_preview") }
2023-02-07 13:17:40 +01:00
let(:guests_permitted) { get_wizard_fixture("wizard/guests_permitted") }
2023-02-09 14:32:01 +01:00
let(:upload_field) { get_wizard_fixture("field/upload") }
let(:validation_condition) { get_wizard_fixture("condition/validation_condition") }
2021-03-11 07:30:15 +01:00
2024-10-16 13:52:03 +02:00
let(:valid_liquid_template) { <<-LIQUID.strip }
{%- assign hello = "Topic Form 1" %}
LIQUID
2024-10-16 13:52:03 +02:00
let(:invalid_liquid_template) { <<-LIQUID.strip }
{%- assign hello = "Topic Form 1" %
LIQUID
2024-10-16 13:52:03 +02:00
let(:liquid_syntax_error) do
"Liquid syntax error: Tag '{%' was not properly terminated with regexp: /\\%\\}/"
2024-10-16 13:52:03 +02:00
end
def expect_validation_success
2024-10-16 13:52:03 +02:00
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(true)
end
def expect_validation_failure(object_id, message)
validator = CustomWizard::TemplateValidator.new(template)
expect(validator.perform).to eq(false)
expect(validator.errors.first.message).to eq("Liquid syntax error in #{object_id}: #{message}")
end
2021-03-11 07:30:15 +01:00
2020-11-03 01:24:20 +01:00
it "validates valid templates" do
2024-10-16 13:52:03 +02:00
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(true)
2020-11-03 01:24:20 +01:00
end
2021-03-11 07:30:15 +01:00
2020-11-03 01:24:20 +01:00
it "invalidates templates without required attributes" do
template.delete(:id)
2024-10-16 13:52:03 +02:00
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(false)
2020-11-03 01:24:20 +01:00
end
2021-03-11 07:30:15 +01:00
2020-11-03 01:24:20 +01:00
it "invalidates templates with duplicate ids if creating a new template" do
CustomWizard::Template.save(template)
2024-10-16 13:52:03 +02:00
expect(CustomWizard::TemplateValidator.new(template, create: true).perform).to eq(false)
2020-11-03 01:24:20 +01:00
end
2021-03-11 07:30:15 +01:00
it "only allows one after signup wizard at a time" do
wizard_id = template[:id]
template[:after_signup] = true
CustomWizard::Template.save(template)
template[:id] = "wizard_2"
template[:after_signup] = true
validator = CustomWizard::TemplateValidator.new(template)
expect(validator.perform).to eq(false)
expect(validator.errors.first.type).to eq(
2024-10-16 13:52:03 +02:00
I18n.t("wizard.validation.after_signup", wizard_id: wizard_id),
)
end
it "only allows a wizard with after signup to be validated twice" do
template[:after_signup] = true
CustomWizard::Template.save(template)
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(true)
end
it "only allows one after _ setting per wizard" do
template[:after_signup] = true
template[:after_time] = true
validator = CustomWizard::TemplateValidator.new(template)
expect(validator.perform).to eq(false)
2024-10-16 13:52:03 +02:00
expect(validator.errors.first.type).to eq(I18n.t("wizard.validation.after_signup_after_time"))
end
2020-11-03 01:24:20 +01:00
it "validates after time settings" do
2020-11-23 01:40:46 +01:00
template[:after_time] = true
template[:after_time_scheduled] = (Time.now + 3.hours).iso8601
2024-10-16 13:52:03 +02:00
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(true)
2020-11-03 01:24:20 +01:00
end
2021-03-11 07:30:15 +01:00
2020-11-03 01:24:20 +01:00
it "invalidates invalid after time settings" do
2020-11-23 01:40:46 +01:00
template[:after_time] = true
2020-11-03 01:24:20 +01:00
template[:after_time_scheduled] = "not a time"
2024-10-16 13:52:03 +02:00
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(false)
2020-11-03 01:24:20 +01:00
end
2021-09-07 14:06:13 +02:00
2021-09-14 05:33:16 +02:00
context "without subscription" do
it "invalidates subscription wizard attributes" do
2024-10-16 13:52:03 +02:00
template[:permitted] = permitted_json["permitted"]
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(false)
2021-09-14 05:33:16 +02:00
end
2021-09-07 14:06:13 +02:00
2021-09-14 05:33:16 +02:00
it "invalidates subscription step attributes" do
2024-10-16 13:52:03 +02:00
template[:steps][0][:condition] = user_condition["condition"]
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(false)
2021-09-14 05:33:16 +02:00
end
2021-09-07 14:06:13 +02:00
2021-09-14 05:33:16 +02:00
it "invalidates subscription field attributes" do
2024-10-16 13:52:03 +02:00
template[:steps][0][:fields][0][:condition] = user_condition["condition"]
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(false)
2021-09-14 05:33:16 +02:00
end
it "invalidates subscription actions" do
template[:actions] << create_category
2024-10-16 13:52:03 +02:00
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(false)
2021-09-14 05:33:16 +02:00
end
2021-09-07 14:06:13 +02:00
end
2021-09-14 05:33:16 +02:00
context "with subscription" do
2024-10-16 13:52:03 +02:00
before { enable_subscription("business") }
2021-09-14 05:33:16 +02:00
it "validates wizard attributes" do
2024-10-16 13:52:03 +02:00
template[:permitted] = permitted_json["permitted"]
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(true)
2021-09-07 14:06:13 +02:00
end
it "validates user-only features" do
2024-10-16 13:52:03 +02:00
template[:permitted] = guests_permitted["permitted"]
2023-02-09 14:32:01 +01:00
template[:steps][0][:fields] << upload_field
2023-02-07 13:17:40 +01:00
validator = CustomWizard::TemplateValidator.new(template)
expect(validator.perform).to eq(false)
errors = validator.errors.to_a
expect(errors).to include(
2024-10-16 13:52:03 +02:00
I18n.t("wizard.validation.not_permitted_for_guests", object_id: "step_2_field_7"),
)
2023-02-07 13:17:40 +01:00
end
2021-09-14 05:33:16 +02:00
it "validates step attributes" do
2024-10-16 13:52:03 +02:00
template[:steps][0][:condition] = user_condition["condition"]
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(true)
2021-09-07 14:06:13 +02:00
end
2021-09-14 05:33:16 +02:00
it "validates field attributes" do
2024-10-16 13:52:03 +02:00
template[:steps][0][:fields][0][:condition] = user_condition["condition"]
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(true)
2021-09-07 14:06:13 +02:00
end
2021-09-14 05:33:16 +02:00
it "validates actions" do
2021-09-07 14:06:13 +02:00
template[:actions] << create_category
2024-10-16 13:52:03 +02:00
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(true)
2021-09-07 14:06:13 +02:00
end
it "validates settings with validation conditions" do
template[:permitted] = validation_condition["condition"]
2024-10-16 13:52:03 +02:00
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(true)
end
2021-09-07 14:06:13 +02:00
end
context "steps" do
CustomWizard::TemplateValidator.required[:step].each do |attribute|
2024-10-16 13:52:03 +02:00
it "invalidates if \"#{attribute}\" is not present" do
template[:steps][0][attribute] = nil
2024-10-16 13:52:03 +02:00
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(false)
end
end
end
context "fields" do
CustomWizard::TemplateValidator.required[:field].each do |attribute|
2024-10-16 13:52:03 +02:00
it "invalidates if \"#{attribute}\" is not present" do
template[:steps][0][:fields][0][attribute] = nil
2024-10-16 13:52:03 +02:00
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(false)
end
end
end
context "actions" do
CustomWizard::TemplateValidator.required[:action].each do |attribute|
2024-10-16 13:52:03 +02:00
it "invalidates if \"#{attribute}\" is not present" do
template[:actions][0][attribute] = nil
2024-10-16 13:52:03 +02:00
expect(CustomWizard::TemplateValidator.new(template).perform).to eq(false)
end
end
end
context "liquid templates" do
it "validates if no liquid syntax in use" do
expect_validation_success
end
it "validates if liquid syntax in use is correct" do
template[:steps][0][:raw_description] = valid_liquid_template
expect_validation_success
end
it "doesn't validate if liquid syntax in use is incorrect" do
template[:steps][0][:raw_description] = invalid_liquid_template
expect_validation_failure("step_1.raw_description", liquid_syntax_error)
end
context "validation targets" do
context "fields" do
it "validates descriptions" do
template[:steps][0][:fields][0][:description] = invalid_liquid_template
expect_validation_failure("step_1_field_1.description", liquid_syntax_error)
end
it "validates placeholders" do
template[:steps][0][:fields][0][:placeholder] = invalid_liquid_template
expect_validation_failure("step_1_field_1.placeholder", liquid_syntax_error)
end
it "validates preview templates" do
2022-03-25 17:08:24 +01:00
enable_subscription("standard")
template[:steps][0][:fields] << composer_preview
template[:steps][0][:fields][3][:preview_template] = invalid_liquid_template
expect_validation_failure("step_1_field_5.preview_template", liquid_syntax_error)
end
end
context "steps" do
it "validates descriptions" do
template[:steps][0][:raw_description] = invalid_liquid_template
expect_validation_failure("step_1.raw_description", liquid_syntax_error)
end
end
context "actions" do
it "validates post builder" do
action = nil
action_index = nil
template[:actions].each_with_index do |a, i|
if a["post_builder"]
action = a
action_index = i
break
end
end
template[:actions][action_index][:post_template] = invalid_liquid_template
expect_validation_failure("#{action[:id]}.post_template", liquid_syntax_error)
end
end
end
end
2021-03-11 07:30:15 +01:00
end